Source/WebKit/chromium/src/WebViewImpl.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebViewImpl.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebKit/chromium/src/WebSearchableFormData.cpp ('K') | « Source/WebKit/chromium/src/WebSelectElement.cpp ('k') | Source/bindings/scripts/CodeGeneratorV8.pm » ('j') | Source/core/accessibility/AccessibilitySlider.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/src/WebViewImpl.cpp

diff --git a/Source/WebKit/chromium/src/WebViewImpl.cpp b/Source/WebKit/chromium/src/WebViewImpl.cpp

index 9065324b93125b9cf5af0ad6e68b473a8a331450..0addbf601c8d797fc3aea80cfb3ec0e94b622e74 100644

--- a/Source/WebKit/chromium/src/WebViewImpl.cpp

+++ b/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -3485,7 +3485,7 @@ void WebViewImpl::applyAutofillSuggestions(

return;

}

- HTMLInputElement* inputElem = focusedNode->toInputElement();

+ Handle<HTMLInputElement> inputElem = focusedNode->toInputElement();

ASSERT(inputElem);

// The first time the Autofill popup is shown we'll create the client and

@@ -3493,8 +3493,7 @@ void WebViewImpl::applyAutofillSuggestions(

if (!m_autofillPopupClient)

m_autofillPopupClient = adoptPtr(new AutofillPopupMenuClient);

- m_autofillPopupClient->initialize(

- inputElem, names, labels, icons, itemIDs, separatorIndex);

+ m_autofillPopupClient->initialize(inputElem.raw(), names, labels, icons, itemIDs, separatorIndex);

if (!m_autofillPopup) {

PopupContainerSettings popupSettings = autofillPopupSettings;