[oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Source/core/html/RadioNodeList.cpp

 /*
  * Copyright (c) 2012 Motorola Mobility, Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 31 matching lines @@
     , m_name(name)
 {
     ScriptWrappable::init(this);
 }
 
 RadioNodeList::~RadioNodeList()
 {
     ownerNode()->nodeLists()->removeCacheWithAtomicName(this, RadioNodeListType, m_name);
 }
 
-static inline HTMLInputElement* toRadioButtonInputElement(Node* node)
+static inline Result<HTMLInputElement> toRadioButtonInputElement(Node* node)
 {
     ASSERT(node->isElementNode());
-    HTMLInputElement* inputElement = node->toInputElement();
+    Handle<HTMLInputElement> inputElement = node->toInputElement();
     if (!inputElement || !inputElement->isRadioButton() || inputElement->value().isEmpty())
-        return 0;
+        return nullptr;
     return inputElement;
 }
 
 String RadioNodeList::value() const
 {
     for (unsigned i = 0; i < length(); ++i) {
         Node* node = item(i);
-        const HTMLInputElement* inputElement = toRadioButtonInputElement(node);
+        Handle<const HTMLInputElement> inputElement = toRadioButtonInputElement(node);

[Vyacheslav Egorov (Google), 2013/07/18 16:50:08]

HandleScope?

[haraken, 2013/07/19 02:57:09]

Done.

         if (!inputElement || !inputElement->checked())
             continue;
         return inputElement->value();
     }
     return String();
 }
 
 void RadioNodeList::setValue(const String& value)
 {
     for (unsigned i = 0; i < length(); ++i) {
         Node* node = item(i);
-        HTMLInputElement* inputElement = toRadioButtonInputElement(node);
+        Handle<HTMLInputElement> inputElement = toRadioButtonInputElement(node);

[Vyacheslav Egorov (Google), 2013/07/18 16:50:08]

HandleScope? (ditto in other loops).

[haraken, 2013/07/19 02:57:09]

Done.

         if (!inputElement || inputElement->value() != value)
             continue;
         inputElement->setChecked(true);
         return;
     }
 }
 
 bool RadioNodeList::checkElementMatchesRadioNodeListFilter(Element* testElement) const
 {
     ASSERT(testElement->hasTagName(objectTag) || testElement->isFormControlElement());
     if (ownerNode()->hasTagName(formTag)) {
         HTMLFormElement* formElement = 0;
         if (testElement->hasTagName(objectTag))
             formElement = static_cast<HTMLObjectElement*>(testElement)->form();
         else
             formElement = static_cast<HTMLFormControlElement*>(testElement)->form();
         if (!formElement || formElement != ownerNode())
             return false;
     }
 
     return testElement->getIdAttribute() == m_name || testElement->getNameAttribute() == m_name;
 }
 
 bool RadioNodeList::nodeMatches(Element* testElement) const
 {
     if (!testElement->hasTagName(objectTag) && !testElement->isFormControlElement())
         return false;
 
-    if (HTMLInputElement* inputElement = testElement->toInputElement()) {
+    if (Handle<HTMLInputElement> inputElement = testElement->toInputElement()) {
         if (inputElement->isImageButton())
             return false;
     }
 
     return checkElementMatchesRadioNodeListFilter(testElement);
 }
 
 } // namspace