[oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Source/WebKit/chromium/src/WebFormControlElement.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "WebFormControlElement.h"
 
 #include "core/html/HTMLFormControlElement.h"
 #include "core/html/HTMLFormElement.h"
+#include "heap/Handle.h"
 #include <wtf/PassRefPtr.h>
 
 using namespace WebCore;
 
 namespace WebKit {
 
 bool WebFormControlElement::isEnabled() const
 {
     return !constUnwrap<HTMLFormControlElement>()->isDisabledFormControl();
 }
@@ skipping 29 matching lines @@
     if (!trimmedName.isEmpty())
         return trimmedName;
     return String();
 }
 
 WebFormElement WebFormControlElement::form() const
 {
     return WebFormElement(constUnwrap<HTMLFormControlElement>()->form());
 }
 
-WebFormControlElement::WebFormControlElement(const PassRefPtr<HTMLFormControlElement>& elem)
-    : WebElement(elem)
+WebFormControlElement::WebFormControlElement(Handle<HTMLFormControlElement> elem)
+    : WebElement(elem.passRefPtr())
 {
 }
 
-WebFormControlElement& WebFormControlElement::operator=(const PassRefPtr<HTMLFormControlElement>& elem)
+WebFormControlElement& WebFormControlElement::operator=(Handle<HTMLFormControlElement> elem)
 {
-    m_private = elem;
+    m_private = elem.passRefPtr();
     return *this;
 }
 
-WebFormControlElement::operator PassRefPtr<HTMLFormControlElement>() const
+WebFormControlElement::operator Handle<HTMLFormControlElement>() const

[Vyacheslav Egorov (Google), 2013/07/18 16:50:08]

I wonder if we want to cast to Handle<T> not to Result<T>?

It seems more natural to cast to Result<T> as this is what we return (similar
how references counting returns PassRefPtr). 

[haraken, 2013/07/19 02:57:09]

I replaced the operator overloading with a normal method getValue().

 {
-    return static_cast<HTMLFormControlElement*>(m_private.get());
+    return Handle<HTMLFormControlElement>(static_cast<HTMLFormControlElement*>(m_private.get()));
 }
 
 } // namespace WebKit