Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: chromeos/network/network_device_handler.h

Issue 19509002: Add support for Device.ProposeScan to NetworkDeviceHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_device_handler.h
diff --git a/chromeos/network/network_device_handler.h b/chromeos/network/network_device_handler.h
index 851f1f9b6a11f5ba218d5378bd3e3ebd54d1d2ab..8270aa6cab11c0d0e3dd64c3d9df42cc1690bca5 100644
--- a/chromeos/network/network_device_handler.h
+++ b/chromeos/network/network_device_handler.h
@@ -61,6 +61,21 @@ class CHROMEOS_EXPORT NetworkDeviceHandler
const base::Closure& callback,
const network_handler::ErrorCallback& error_callback);
+ // Requests a network scan on the device specified by |device_path|.
+ // For cellular networks, the result of this call gets asynchronously stored
+ // in the corresponding DeviceState object through a property update. For all
+ // other technologies a service gets created for each found network, which
+ // can be accessed through the corresponding NetworkState object.
+ //
+ // TODO(armansito): Device.ProposeScan is deprecated and the preferred method
+ // of requesting a network scan is Manager.RequestScan, however shill
+ // currently doesn't support cellular network scans via Manager.RequestScan.
+ // Remove this method once shill supports that.
gauravsh 2013/07/19 22:59:35 Can you file a bug and reference it here as well?
armansito 2013/07/19 23:20:02 Done.
+ void ProposeScan(
+ const std::string& device_path,
+ const base::Closure& callback,
+ const network_handler::ErrorCallback& error_callback);
+
// Tells the device to set the modem carrier firmware, as specified by
// |carrier|.
//

Powered by Google App Engine
This is Rietveld 408576698