Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1950893003:
[tracing] Support background mode in dom storage memory dumps (Closed)
Description[tracing] Support background mode in dom storage memory dumps
Provide just total numbers for background mode dumps in dom storage.
The storage could be using memory for commit batches along with the
storage maps. So, add the size to tracing.
BUG=613198, 605785
TBR=michaeln
Committed: https://crrev.com/659a76cbecfd264aa1c04c113e5d0a03b88038fc
Cr-Commit-Position: refs/heads/master@{#398499}
Patch Set 1 : #Patch Set 2 : #
Messages
Total messages: 22 (13 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [tracing] Add the usage of DOM storage commit batches to tracing The storage could be using memory for commit batches along with the storage maps. BUG=605785 ========== to ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. BUG=613198, 605785 ==========
Description was changed from ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. BUG=613198, 605785 ========== to ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 ==========
Description was changed from ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 ========== to ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background mode dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 ==========
Patchset #2 (id:40001) has been deleted
ssid@chromium.org changed reviewers: + michaeln@chromium.org
This is a fix to make the tracing lighter depending on the mode of the memory snapshot. PTAL, Thanks.
On 2016/06/01 20:46:48, ssid wrote: > This is a fix to make the tracing lighter depending on the mode of the memory > snapshot. > PTAL, Thanks. friendly ping.
ssid@chromium.org changed reviewers: + jsbell@chromium.org
+jsbell since michaeln is OOO. This only changes the tracing code of dom_storage. ptal, thanks
lgtm
Description was changed from ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background mode dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 ========== to ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background mode dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 TBR=michaeln ==========
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950893003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by ssid@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950893003/60001
Message was sent while issue was closed.
Description was changed from ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background mode dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 TBR=michaeln ========== to ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background mode dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 TBR=michaeln ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background mode dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 TBR=michaeln ========== to ========== [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background mode dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG=613198, 605785 TBR=michaeln Committed: https://crrev.com/659a76cbecfd264aa1c04c113e5d0a03b88038fc Cr-Commit-Position: refs/heads/master@{#398499} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/659a76cbecfd264aa1c04c113e5d0a03b88038fc Cr-Commit-Position: refs/heads/master@{#398499} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
