Fix button 1 being stuck down on certain Logitech gamepads on Windows

Fix button 1 being stuck down on certain Logitech gamepads on Windows

There are HID elements in these gamepads classified as buttons which
don't use the usage page value for buttons. These elements don't actually
correspond to real buttons on the controller, and are stuck in the pressed
position. On OSX, we skip these "fake" buttons, but we didn't on Windows.
As a result, a HID element would overlap with button 1 and make it appear
to be constantly pressed.

R=bajones@chromium.org

BUG=600230
Committed: https://crrev.com/a8d9d22865f445b8f6f2b9814fb919b8008fbc5c
Cr-Commit-Position: refs/heads/master@{#391616}

[cgutman, 2016-05-04 03:07:40]

I ran into this issue a few weeks ago and finally took a look. A HID dump on OS
X showed:

Element: 0x100106b30 = { parent: 0x100106ab0, cookie: 0x00000005, type: Button,
usage: 0x0009:0x0001, report: { ID: 0, Size: 1, Count: 1 }, logical: {min: 0,
max: 1}, physical: {min: 0, max: 1}, hasPreferredState,  }
[...]
Element: 0x1001073b0 = { parent: 0x100106ab0, cookie: 0x00000011, type: Button,
usage: 0xFF00:0x0001, report: { ID: 0, Size: 1, Count: 1 }, logical: {min: 0,
max: 1}, physical: {min: 0, max: 1}, hasPreferredState,  }

That second element was reporting a value of 1 constantly which caused the HID
code on Windows to think button 1 was pressed when it wasn't

[bajones, 2016-05-04 16:51:49]

Works great on the gamepads I've seen this behavior from in the past! Thank you
for doing the research needed to pinpoint the problem! This has been on my TODO
list for a while but I've never had a chance to really look into it.

LGTM.

[bajones, 2016-05-04 16:51:53]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-05-04 16:52:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950883002/1

[commit-bot: I haz the power, 2016-05-04 20:08:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-04 20:10:16]

Description was changed from

==========
Fix button 1 being stuck down on certain Logitech gamepads on Windows

There are HID elements in these gamepads classified as buttons which
don't use the usage page value for buttons. These elements don't actually
correspond to real buttons on the controller, and are stuck in the pressed
position. On OSX, we skip these "fake" buttons, but we didn't on Windows.
As a result, a HID element would overlap with button 1 and make it appear
to be constantly pressed.

R=bajones@chromium.org

BUG=600230
==========

to

==========
Fix button 1 being stuck down on certain Logitech gamepads on Windows

There are HID elements in these gamepads classified as buttons which
don't use the usage page value for buttons. These elements don't actually
correspond to real buttons on the controller, and are stuck in the pressed
position. On OSX, we skip these "fake" buttons, but we didn't on Windows.
As a result, a HID element would overlap with button 1 and make it appear
to be constantly pressed.

R=bajones@chromium.org

BUG=600230

Committed: https://crrev.com/a8d9d22865f445b8f6f2b9814fb919b8008fbc5c
Cr-Commit-Position: refs/heads/master@{#391616}
==========

[commit-bot: I haz the power, 2016-05-04 20:10:16]

Patchset 1 (id:??) landed as
https://crrev.com/a8d9d22865f445b8f6f2b9814fb919b8008fbc5c
Cr-Commit-Position: refs/heads/master@{#391616}