Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/ast/scopes.cc

Issue 1950803002: Don't treat catch scopes as possibly-shadowing for sloppy eval (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use is_declaration_scope instead of !is_catch_scope Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-608279.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index 2372e1bb1d4b944a4acb668d1ff325c9199d0fd3..aa3685fca4cad49747a887771f530514698b5f79 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -1098,8 +1098,8 @@ Variable* Scope::LookupRecursive(VariableProxy* proxy,
if (var != NULL && proxy->is_assigned()) var->set_maybe_assigned();
*binding_kind = DYNAMIC_LOOKUP;
return NULL;
- } else if (calls_sloppy_eval() && !is_script_scope() &&
- name_can_be_shadowed) {
+ } else if (calls_sloppy_eval() && is_declaration_scope() &&
+ !is_script_scope() && name_can_be_shadowed) {
// A variable binding may have been found in an outer scope, but the current
Dan Ehrenberg 2016/05/04 20:54:08 Could you briefly mention in this comment that non
adamk 2016/05/04 21:06:18 Done.
// scope makes a sloppy 'eval' call, so the found variable may not be
// the correct one (the 'eval' may introduce a binding with the same name).
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-608279.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698