Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1950793002: 🎯 Reland of Fail if an instrumentation test is missing size annotation (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, kjellander_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fail if an instrumentation test is missing size annotation Changes since last one: SiteSettingsPreferencesTest.testBackgroundSyncPermission now named as a helper instead of annotated as a test. TBR=jbudorick@chromium.org,sgurun@chromium.org,yfriedman@chromium.org,mathp@chromium.org BUG=601464 Committed: https://crrev.com/01c2d6a9bdc61d422d8af9589ca0a0830d853ec1 Cr-Commit-Position: refs/heads/master@{#391421}

Patch Set 1 #

Patch Set 2 : Fix helper method #

Messages

Total messages: 8 (4 generated)
agrieve
Created Reland of 🎯 Fail if an instrumentation test is missing size annotation
4 years, 7 months ago (2016-05-04 00:29:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950793002/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950793002/190001
4 years, 7 months ago (2016-05-04 00:36:00 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:190001)
4 years, 7 months ago (2016-05-04 02:28:34 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 02:29:47 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01c2d6a9bdc61d422d8af9589ca0a0830d853ec1
Cr-Commit-Position: refs/heads/master@{#391421}

Powered by Google App Engine
This is Rietveld 408576698