Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 1950733002: Add unit test for request coordiator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More CR feedback per FGorski Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index 47991061dba95200a826cfac6abb9289ce0d0736..b25bf4bbf78887d099d7d5f87f272e208d4a15b8 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -9,22 +9,21 @@
namespace offline_pages {
+class SavePageRequest;
+
// Coordinates queueing and processing save page later requests.
class RequestCoordinator {
public:
// Callback to report when the processing of a triggered task is complete.
typedef base::Callback<void()> ProcessingDoneCallback;
- struct SavePageRequest {
- // TODO(dougarnett): define and consider making stand-alone.
- };
-
// TODO(dougarnett): How to inject Offliner factories and policy objects.
RequestCoordinator();
~RequestCoordinator();
// Queues |request| to later load and save when system conditions allow.
+ // Returns true if the page could be queued successfully.
bool SavePageLater(const SavePageRequest& request);
// Starts processing of one or more queued save page later requests.

Powered by Google App Engine
This is Rietveld 408576698