Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1950713006: Clean up GrVkImage::setLayout() (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up GrVkImage::setLayout() Fixes issues with mipmap generation, and calculates src information inside the routine rather than having the client do it. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950713006 Committed: https://skia.googlesource.com/skia/+/50c46c7b189caf94abb79cdc125245a6c0de0b4e

Patch Set 1 #

Patch Set 2 : Remove some unnecessary variables #

Patch Set 3 : Fix one set of flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -213 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 1 2 14 chunks +62 lines, -183 lines 0 comments Download
M src/gpu/vk/GrVkImage.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/gpu/vk/GrVkImage.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jvanverth1
4 years, 7 months ago (2016-05-06 14:22:15 UTC) #3
egdaniel
lgtm
4 years, 7 months ago (2016-05-06 18:45:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950713006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950713006/40001
4 years, 7 months ago (2016-05-06 19:07:32 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 19:31:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/50c46c7b189caf94abb79cdc125245a6c0de0b4e

Powered by Google App Engine
This is Rietveld 408576698