Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1950703002: [Mac][Material Design] Update toolbar bottom border color. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, asanka, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Update toolbar bottom border color. This cl updates the border color at the bottom of the toolbar (when the bookmarks bar is in NTP mode) and other locations to the correct value for Material Design. R=avi@chromium.org BUG=593436 Committed: https://crrev.com/95661b05d996a9b77ae2738f71533be79e3c888d Cr-Commit-Position: refs/heads/master@{#394885}

Patch Set 1 #

Patch Set 2 : Refine code. #

Patch Set 3 : Code cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M chrome/browser/ui/cocoa/background_gradient_view.mm View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.mm View 1 2 2 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-19 20:21:44 UTC) #4
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-19 20:24:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950703002/40001
4 years, 7 months ago (2016-05-19 21:00:48 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 22:10:54 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 22:13:29 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95661b05d996a9b77ae2738f71533be79e3c888d
Cr-Commit-Position: refs/heads/master@{#394885}

Powered by Google App Engine
This is Rietveld 408576698