Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1950633003: Fix exit code handling for Android testing. (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 7 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix exit code handling for Android testing. Shell returns 128+N when exiting because of signal. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/b0f4ccabf4b4810efd379eed45a8ded57cf7185b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/testing/dart/android.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 7 months ago (2016-05-03 21:06:12 UTC) #2
kustermann
LGTM
4 years, 7 months ago (2016-05-04 07:01:05 UTC) #3
Florian Schneider
4 years, 7 months ago (2016-05-04 08:13:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0f4ccabf4b4810efd379eed45a8ded57cf7185b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698