Issue 195063002: Fix bug in constant folding object comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195063002: Fix bug in constant folding object comparisons. (Closed)

Created:
6 years, 9 months ago by Yang

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bug in constant folding object comparisons. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19798

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -30 lines)			Patch
M	src/hydrogen-instructions.h	View	1	4 chunks	+26 lines, -27 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-346587.js	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://codereview.chromium.org/195063002/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/195063002/diff/1/src/hydrogen-instructions.h#newcode4309 src/hydrogen-instructions.h:4309: // TODO(danno): make this private when ...

6 years, 9 months ago (2014-03-11 13:30:21 UTC) #2

Yang

On 2014/03/11 13:30:21, Jakob wrote: > LGTM with comment. > > https://codereview.chromium.org/195063002/diff/1/src/hydrogen-instructions.h > File src/hydrogen-instructions.h ...

6 years, 9 months ago (2014-03-11 13:33:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19798 (tree was closed).

Expand Messages | Collapse Messages

Issue 195063002: Fix bug in constant folding object comparisons. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages