third_party/WebKit/LayoutTests/netinfo/gc-frame-listeners.html - Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/netinfo/gc-frame-listeners.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes comments and fixes more tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-lifetime.html ('k') | third_party/WebKit/LayoutTests/netinfo/gc-unused-listeners.html » ('j') | third_party/WebKit/LayoutTests/resources/observeGC.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/netinfo/gc-frame-listeners.html

diff --git a/third_party/WebKit/LayoutTests/netinfo/gc-frame-listeners.html b/third_party/WebKit/LayoutTests/netinfo/gc-frame-listeners.html

index 10ec4fb82fc8bd698b73ada8174b9d071dd83fdf..f7e1c2e4f3a1e0c25c88069e833e330e580eb767 100644

--- a/third_party/WebKit/LayoutTests/netinfo/gc-frame-listeners.html

+++ b/third_party/WebKit/LayoutTests/netinfo/gc-frame-listeners.html

@@ -1,6 +1,7 @@

<!DOCTYPE html>

<head>

+<script src="../resources/observeGC.js"></script>

</head>

<body>

@@ -12,17 +13,17 @@ shouldBe('typeof window.internals.observeGC', '"function"',

'this test requires window.internals');

var childFrame = document.createElement('iframe');

-var childFrameObserver = internals.observeGC(childFrame);

+var childFrameObserver = observeGC(() => {return childFrame;});

document.body.appendChild(childFrame);

var childConnection = childFrame.contentWindow.navigator.connection;

-var childConnectionObserver = internals.observeGC(childConnection);

+var childConnectionObserver = observeGC(() => {return childConnection;});

var callback = function(e) {

testFailed("Should not get here.");

};

-var callbackObserver = internals.observeGC(callback);

+var callbackObserver = observeGC(() => {return callback;});

// Add the event listener and make sure it doesn't get collected.

childConnection.addEventListener('typechange', callback);