third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html - Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes comments and fixes more tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html ('k') | third_party/WebKit/LayoutTests/fast/harness/internals-observe-gc.html » ('j') | third_party/WebKit/LayoutTests/resources/observeGC.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html b/third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

index 96fe55a72d4b4bb46c6bc779903bb03290ec671f..9268eaacfcf01e6c19d871a9a04461182fa8c9a1 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

@@ -2,6 +2,7 @@

<html>

<body>

+<script src="../../../resources/observeGC.js"></script>

var callbackWasTriggered = false;

@@ -11,10 +12,10 @@

};

var nodeIterator = document.createNodeIterator(document, NodeFilter.SHOW_ELEMENT, callback, false);

- var callbackObservation = internals.observeGC(callback);

+ var callbackObservation = observeGC(() => {return callback;});

callback = null;

- var nodeFilterObservation = internals.observeGC(nodeIterator.filter);

- var nodeIteratorObservation = internals.observeGC(nodeIterator);

+ var nodeFilterObservation = observeGC(() => {return nodeIterator.filter;});

+ var nodeIteratorObservation = observeGC(() => {return nodeIterator;});

gc();

shouldBeFalse('nodeFilterObservation.wasCollected');