Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/cursor-leak.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed special wrapper for internals.observeGC. Adds an inner function to pass the object. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/netinfo/gc-unused-listeners.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/storage/indexeddb/cursor-leak.html
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/cursor-leak.html b/third_party/WebKit/LayoutTests/storage/indexeddb/cursor-leak.html
index abeabf87944aeb4aa06633e6a0daa942e93df0d3..6fbda670510d9e452212b566256119c293bd8e87 100644
--- a/third_party/WebKit/LayoutTests/storage/indexeddb/cursor-leak.html
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/cursor-leak.html
@@ -40,7 +40,11 @@ function onOpen(evt)
cursor.primaryKey.cursor = cursor;
cursor.value.cursor = cursor;
- cursorObserver = internals.observeGC(cursor);
+ // Do not pass the object directly to observeGC function. This may
+ // remain live on this function's stack preventing GC from collecting
+ // it. Accessing the object inside an inner function will prevent any
+ // unneeded references on this function's stack.
+ cursorObserver = internals.observeGC((() => {return cursor;})());
cursorRequest = null;
cursor = null;
« no previous file with comments | « third_party/WebKit/LayoutTests/netinfo/gc-unused-listeners.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698