third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html - Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed line couloum width. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html ('K') | « third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html ('k') | third_party/WebKit/LayoutTests/resources/observeGCWrapper.js » ('j') | third_party/WebKit/LayoutTests/resources/observeGCWrapper.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <div>Test passes if it does not crash</div>	2 <div>Test passes if it does not crash</div>

3 <script src="../../../resources/gc.js"></script>	3 <script src="../../../resources/gc.js"></script>

4 <script>	4 <script>

5 if (window.testRunner) {	5 if (window.testRunner) {

6 testRunner.waitUntilDone();	6 testRunner.waitUntilDone();

7 testRunner.dumpAsText();	7 testRunner.dumpAsText();

8 }	8 }

9 var observer = new MutationObserver(function() {console.log('Should not appear') });	9 var observer, div;

10 var div = document.createElement('div');	10 function initializeObserver() {

11 observer.observe(div, {attributes: true});	11 observer = new MutationObserver(function() {console.log('Should not appear')}) ;

12 div.id = 'foo';	12 div = document.createElement('div');

	13 observer.observe(div, {attributes: true});

	14 div.id = 'foo';

	15 }

	16

	17 initializeObserver();

13 div = null;	18 div = null;

14 observer = null;	19 observer = null;

15 gc();	20 gc();

16 setTimeout(function() { testRunner.notifyDone(); }, 0);	21 setTimeout(function() { testRunner.notifyDone(); }, 0);

17 </script>	22 </script>

OLD	NEW