Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1950613002: Adds more DBC assembler tests (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -0 lines) Patch
M runtime/vm/assembler_dbc_test.cc View 1 chunk +311 lines, -0 lines 0 comments Download
M runtime/vm/constants_dbc.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 7 months ago (2016-05-03 19:46:45 UTC) #2
Vyacheslav Egorov (Google)
LGTM!
4 years, 7 months ago (2016-05-03 20:08:11 UTC) #3
zra
4 years, 7 months ago (2016-05-03 20:55:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13c740f4bd99e9f2c49d483e877224157bd66d8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698