Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1950583002: Further bitop optimizations (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Further bitop optimizations - avoid unsigned coercion when result is compared with constant - avoid unsigned coercion when result is shifted right unsigned - avoid call when right shift result has bits affected by sign bit masked out - use values of named constants R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/48d75079fbdf95db90a65ef5985863853222bb87

Patch Set 1 #

Patch Set 2 : (x >> N) & M #

Patch Set 3 : bugfix + understand named constants #

Patch Set 4 : merge #

Patch Set 5 : #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -110 lines) Patch
M lib/runtime/dart_sdk.js View 1 2 3 4 5 44 chunks +87 lines, -87 lines 0 comments Download
M lib/src/compiler/code_generator.dart View 1 2 3 4 5 6 chunks +69 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
This CL results in a lot of good changes in the Int64 class.
4 years, 6 months ago (2016-06-03 03:37:47 UTC) #4
vsm
lgtm
4 years, 6 months ago (2016-06-03 20:36:36 UTC) #5
sra1
4 years, 6 months ago (2016-06-03 21:29:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
48d75079fbdf95db90a65ef5985863853222bb87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698