third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp - Issue 1950573003: Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

Issue 1950573003: Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LocationChange

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

index b83373f094335435cb04a56ebeb276e548451ecc..7c03b795357f003b092eab2558f5002b96cb771d 100644

--- a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

+++ b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

@@ -27,11 +27,11 @@ protected:

Vector<LayoutObject*> pendingDelayedPaintInvalidations;

paintInvalidationStates[0].emplace(layoutView, pendingDelayedPaintInvalidations);

if (layoutView != object)

- paintInvalidationStates[0]->updateForChildren();

+ paintInvalidationStates[0]->updateForChildren(PaintInvalidationFull);

for (size_t i = 1; i < paintInvalidationStates.size(); ++i) {

paintInvalidationStates[i].emplace(*paintInvalidationStates[i - 1], *ancestors[ancestors.size() - i]);

if (paintInvalidationStates[i]->m_currentObject != object)

- paintInvalidationStates[i]->updateForChildren();

+ paintInvalidationStates[i]->updateForChildren(PaintInvalidationFull);

}

const PaintInvalidationState& paintInvalidationState = *paintInvalidationStates.last();