third_party/WebKit/Source/core/layout/LayoutTable.cpp - Issue 1950573003: Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 1950573003: Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LocationChange

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/PaintInvalidationState.h » ('j') | third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

index 134171ae6b7d80aa753585d5f048ea073d0b6afd..751894385f45d0bb12d9217c12778e52aa177331 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

@@ -1442,7 +1442,8 @@ void LayoutTable::invalidatePaintOfSubtreesIfNeeded(const PaintInvalidationState

// Table cells paint container's background on the container's backing instead of its own (if any),

// so we must invalidate it by the containers.

bool invalidated = false;

- if ((columnGroup && columnGroup->shouldDoFullPaintInvalidation())

+ if (childPaintInvalidationState.forcedSubtreeFullInvalidationWithinContainer()

chrishtr 2016/05/09 22:20:42 Why the change here?

+ || (columnGroup && columnGroup->shouldDoFullPaintInvalidation())

|| (column && column->shouldDoFullPaintInvalidation())

|| section->shouldDoFullPaintInvalidation()) {

section->invalidateDisplayItemClient(*cell);