third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 1950573003: Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 1950573003: Improve handling of PaintInvalidationLayer (renamed to PaintInvalidationSubtree) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LocationChange

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index de88310f5786ba342e80b7a2ff454b9945d4e90e..ed980f55e816c8f255d71ce21d71b6edfa2278a8 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -1355,11 +1355,7 @@ public:

bool shouldCheckForPaintInvalidation(const PaintInvalidationState& paintInvalidationState) const

{

- // Should check for paint invalidation if some ancestor changed location, because this object

- // may also change paint offset or location in paint invalidation container, even if there is

- // no paint invalidation flag set.

- return paintInvalidationState.forcedSubtreeInvalidationWithinContainer()

- || paintInvalidationState.forcedSubtreeInvalidationRectUpdateWithinContainer()

+ return paintInvalidationState.hasForcedSubtreeInvalidationFlags()

|| shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState();

}

@@ -1511,7 +1507,7 @@ protected:

void setPreviousPaintInvalidationRect(const LayoutRect& rect) { m_previousPaintInvalidationRect = rect; }

- virtual PaintInvalidationReason getPaintInvalidationReason(const LayoutBoxModelObject& paintInvalidationContainer,

+ virtual PaintInvalidationReason getPaintInvalidationReason(const PaintInvalidationState&,

const LayoutRect& oldPaintInvalidationRect, const LayoutPoint& oldPositionFromPaintInvalidationBacking,

const LayoutRect& newPaintInvalidationRect, const LayoutPoint& newPositionFromPaintInvalidationBacking) const;