Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1950563006: Reland: Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac (Closed)

Created:
4 years, 7 months ago by emircan
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac This CL tries adding this feature again after the fix landed on https://codereview.chromium.org/1928873002/ that solves HW encoder issues. Original CL description: Additional to the original, this CL checks for >=OSX10.9 in content/common/gpu/media/vt_video_encode_accelerator_mac.cc since VideoToolbox HW features are introduced there. The original CL got reverted because of a failure on a bot running 10.8.5. https://developer.apple.com/library/mac/releasenotes/General/APIDiffsMacOSX10_9/VideoToolbox.html https://codereview.chromium.org/1852523002/ This CL enables using VideoToolbox encoder when kWebRtcH264WithOpenH264FFmpeg flag is on. BUG=597334 TBR=mcasas@chromium.org, hbos@chromium.org, sandersd@chromium.org Committed: https://crrev.com/f8ec6afcc3998e96bcaf0a7a7ac24c979b40a83f Cr-Commit-Position: refs/heads/master@{#392454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_encoder_factory.cc View 2 chunks +8 lines, -1 line 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
emircan
4 years, 7 months ago (2016-05-09 19:47:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950563006/1
4 years, 7 months ago (2016-05-09 20:28:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 22:48:22 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 22:50:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8ec6afcc3998e96bcaf0a7a7ac24c979b40a83f
Cr-Commit-Position: refs/heads/master@{#392454}

Powered by Google App Engine
This is Rietveld 408576698