Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1950563004: Retire some memcheck and Dr. Memory suppressions for CSS code (Closed)

Created:
4 years, 7 months ago by Timothy Loh
Modified:
4 years, 7 months ago
Reviewers:
dstockwell
CC:
bruening+watch_chromium.org, chromium-reviews, glider+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retire some memcheck and Dr. Memory suppressions for CSS code This patch removes several suppressions for memcheck and Dr. Memory: 343797, 343915: The Bison CSS parser no longer exists (crbug.com/489144) 492821: The CSS property parser has been rewritten (crbug.com/499780) 591092: This bug has been fixed (crbug.com/590801) BUG=343797, 343915, 492821, 591092 Committed: https://crrev.com/6988d5badc6ee8330101e9dd21a92405672a05be Cr-Commit-Position: refs/heads/master@{#391970}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 3 chunks +0 lines, -44 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Timothy Loh
4 years, 7 months ago (2016-05-05 08:50:32 UTC) #3
dstockwell
lgtm
4 years, 7 months ago (2016-05-05 10:01:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950563004/20001
4 years, 7 months ago (2016-05-05 23:32:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 00:44:08 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 00:45:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6988d5badc6ee8330101e9dd21a92405672a05be
Cr-Commit-Position: refs/heads/master@{#391970}

Powered by Google App Engine
This is Rietveld 408576698