Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1950563003: [Media Router WebUI] Make blue color styling darker. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Make blue color styling darker. Currently, paper blue 500 and white do not have enough contrast. This change replaces all usages of paper blue 500 with 700, which is the next darkest paper blue color that passes the accessibility audit. This fixes the AX_COLOR_01 warnings related to the blue color. BUG=609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8c672ef5004a61ed85419fa924637a5630d2c78a Cr-Commit-Position: refs/heads/master@{#391633}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media_router/media_router_common.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
apacible
PTAL, thanks! The new blue looks like: https://screenshot.googleplex.com/MMv9TBTQzVW.png
4 years, 7 months ago (2016-05-04 17:30:06 UTC) #6
imcheng
lgtm
4 years, 7 months ago (2016-05-04 19:31:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950563003/20001
4 years, 7 months ago (2016-05-04 20:37:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-04 20:49:03 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:50:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c672ef5004a61ed85419fa924637a5630d2c78a
Cr-Commit-Position: refs/heads/master@{#391633}

Powered by Google App Engine
This is Rietveld 408576698