Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1950553003: Revert of Re-enable multi-process IPC tests on Android. (Closed)

Created:
4 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-android-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable multi-process IPC tests on Android. (patchset #3 id:40001 of https://codereview.chromium.org/1914143004/ ) Reason for revert: They are breaking various downstream bots: https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone Original issue's description: > Re-enable multi-process IPC tests on Android. > > This is possible by using the alternate test child implementation. > > Committed: https://crrev.com/3f7857b03d9560943c20e88f3802aefe082fcdbf > Cr-Commit-Position: refs/heads/master@{#391178} TBR=tsepez@chromium.org,amistry@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/ddf19997cef9587a0a6423b5e3c5c77c61c9d00f Cr-Commit-Position: refs/heads/master@{#391498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -35 lines) Patch
M ipc/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 7 chunks +22 lines, -16 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ipc/ipc_test_base.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ipc/run_all_unittests.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
mlamouri (slow - plz ping)
Created Revert of Re-enable multi-process IPC tests on Android.
4 years, 7 months ago (2016-05-04 12:53:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950553003/1
4 years, 7 months ago (2016-05-04 12:54:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950553003/1
4 years, 7 months ago (2016-05-04 13:01:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950553003/1
4 years, 7 months ago (2016-05-04 13:31:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 13:56:15 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 13:57:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddf19997cef9587a0a6423b5e3c5c77c61c9d00f
Cr-Commit-Position: refs/heads/master@{#391498}

Powered by Google App Engine
This is Rietveld 408576698