Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1950553002: VM: Remove PushTempInstr, simplify SSA renaming. (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Remove PushTempInstr, simplify SSA renaming. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/f54c8d89fa6291558e78ee3d9872750e257e201f

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -87 lines) Patch
M runtime/vm/constant_propagator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 5 chunks +10 lines, -23 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_dbc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +0 lines, -29 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 7 months ago (2016-05-03 18:51:12 UTC) #2
Vyacheslav Egorov (Google)
LGTM! https://codereview.chromium.org/1950553002/diff/1/runtime/vm/flow_graph.cc File runtime/vm/flow_graph.cc (right): https://codereview.chromium.org/1950553002/diff/1/runtime/vm/flow_graph.cc#newcode1100 runtime/vm/flow_graph.cc:1100: } I think this can be rewritten as: ...
4 years, 7 months ago (2016-05-03 20:04:52 UTC) #3
Florian Schneider
Committed patchset #2 (id:20001) manually as f54c8d89fa6291558e78ee3d9872750e257e201f (presubmit successful).
4 years, 7 months ago (2016-05-04 08:54:10 UTC) #5
Florian Schneider
4 years, 7 months ago (2016-05-09 14:47:20 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1950553002/diff/1/runtime/vm/flow_graph.cc
File runtime/vm/flow_graph.cc (right):

https://codereview.chromium.org/1950553002/diff/1/runtime/vm/flow_graph.cc#ne...
runtime/vm/flow_graph.cc:1100: }
On 2016/05/03 20:04:51, Vyacheslav Egorov (Google) wrote:
> I think this can be rewritten as:
> 
> if (input_defn != reaching_defn) {
>   // ...
>   v->set_definition(reaching_defn);
>   input_defn = reaching_defn;
> }

This should work - it's a little subtle. I'll add a documenting ASSERT that
input_defn is one of LoadLocal, StoreLocal, DropTemps or Constant

Powered by Google App Engine
This is Rietveld 408576698