Create Pepper-based CDM for EME WD (Blink changes)

Source/modules/encryptedmedia/MediaKeysController.h

Index: Source/modules/encryptedmedia/MediaKeysController.h
diff --git a/Source/modules/encryptedmedia/MediaKeysController.h b/Source/modules/encryptedmedia/MediaKeysController.h
new file mode 100644
index 0000000000000000000000000000000000000000..fc77fac6b2ea6c0839308f8223065c9b3b8e0b57
--- /dev/null
+++ b/Source/modules/encryptedmedia/MediaKeysController.h
@@ -0,0 +1,59 @@
+/*

[ddorwin, 2014/03/12 01:01:09]

ditto

[jrummell, 2014/03/17 20:48:37]

Done.

+ * Copyright (C) 2014 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef MediaKeysController_h
+#define MediaKeysController_h
+
+#include "core/page/Page.h"
+#include "modules/encryptedmedia/MediaKeysClient.h"

[ddorwin, 2014/03/12 01:01:09]

fwd declare

[jrummell, 2014/03/17 20:48:37]

Done.

+#include "wtf/PassOwnPtr.h"
+
+namespace WebCore {
+
+class MediaKeysController FINAL : public Supplement<Page> {

[ddorwin, 2014/03/12 01:01:09]

I wonder whether Controller is the right name. Do the other controllers actually
do controlling?

[jrummell, 2014/03/17 20:48:37]

Most of the controllers I looked at (UserMediaController, MIDIController,
SpeechRecognitionController) do little work other than provide access to the
client (either as client() or by providing inline methods that call
m_client->something()).

+public:
+    virtual ~MediaKeysController();
+    MediaKeysClient* client() const { return m_client; }

[ddorwin, 2014/03/12 01:01:09]

Is use of "const" common? We usually don't use const when returning non-const
pointers.

[jrummell, 2014/03/17 20:48:37]

I just copied what was in UserMediaController.h. Could also get rid of client(),
and create a passthru method createContentDecryptionModule().

[ddorwin, 2014/03/17 21:47:43]

Yeah, I don't see an advantage to having the client pointer be separate in this
case. We're not passing it anywhere. Of course, sticking with consistent
patterns is nice.

[jrummell, 2014/03/17 22:42:13]

Done. Converted to a passthru method rather than exposing client() that could
get misused.

+
+    static PassOwnPtr<MediaKeysController> create(MediaKeysClient*);
+    static const char* supplementName();
+    static MediaKeysController* from(Page* page) { return static_cast<MediaKeysController*>(Supplement<Page>::from(page, supplementName())); }
+
+protected:
+    explicit MediaKeysController(MediaKeysClient*);
+
+private:
+    MediaKeysClient* m_client;
+};
+
+} // namespace WebCore
+
+#endif // MediaKeysController_h
+