Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1950513002: Reland of Turn on MojoChannel (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Turn on MojoChannel (patchset #1 id:1 of https://codereview.chromium.org/1946573002/ ) Reason for revert: The underlying cause of the flake has been fixed in Mojo. This can be relanded now. Original issue's description: > Revert of Turn on MojoChannel (patchset #1 id:1 of https://codereview.chromium.org/1941003002/ ) > > Reason for revert: > Speculative revert for https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29?numbuilds=200 > > Original issue's description: > > Turn on MojoChannel > > > > Removes --enable-mojo-channel and the MojoChannel field > > trial. Turns on MojoChannel permanently. > > > > BUG=595082 > > > > Committed: https://crrev.com/1e213694248b28e9f15be63c006009e249063808 > > Cr-Commit-Position: refs/heads/master@{#391029} > > TBR=jam@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=595082 > > Committed: https://crrev.com/5c43b108e3c78b8e1f9cf67cd1cc0771941ba5fe > Cr-Commit-Position: refs/heads/master@{#391219} TBR=jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595082 Committed: https://crrev.com/88c27242702c9c3d1fb5cd29d9cd9cf099bfa5ec Cr-Commit-Position: refs/heads/master@{#391293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -88 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +13 lines, -35 lines 0 comments Download
M content/public/common/mojo_channel_switches.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/common/mojo_channel_switches.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 2 chunks +1 line, -9 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ken Rockot(use gerrit already)
Created Reland of Turn on MojoChannel
4 years, 7 months ago (2016-05-03 18:00:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950513002/1
4 years, 7 months ago (2016-05-03 18:00:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:01:43 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:03:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88c27242702c9c3d1fb5cd29d9cd9cf099bfa5ec
Cr-Commit-Position: refs/heads/master@{#391293}

Powered by Google App Engine
This is Rietveld 408576698