Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/app_shim/BUILD.gn

Issue 1950493002: [Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/mac/rules.gni") 5 import("//build/config/mac/rules.gni")
6 import("//build/util/branding.gni")
6 7
7 # This is the part of the shim process compiled into Chrome. It runs only 8 # This is the part of the shim process compiled into Chrome. It runs only
8 # in the shim process, after the shim finds and loads the Chrome 9 # in the shim process, after the shim finds and loads the Chrome
9 # Framework bundle. 10 # Framework bundle.
10 source_set("app_shim") { 11 source_set("app_shim") {
11 sources = [ 12 sources = [
12 "chrome_main_app_mode_mac.mm", 13 "chrome_main_app_mode_mac.mm",
13 ] 14 ]
14 15
15 deps = [ 16 deps = [
16 "//chrome:strings", 17 "//chrome:strings",
17 "//chrome/common:app_mode_app_support", 18 "//chrome/common:app_mode_app_support",
18 ] 19 ]
19 } 20 }
20 21
21 mac_app_bundle("app_mode_loader") { 22 mac_app_bundle("app_mode_loader") {
22 extra_configs = [ "//build/config/compiler:wexit_time_destructors" ] 23 extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
23 24
24 info_plist = "app_mode-Info.plist" 25 info_plist = "app_mode-Info.plist"
26 extra_substitutions = [ "APP_MODE_APP_BUNDLE_ID=$chrome_mac_bundle_id.app.@APP _MODE_SHORTCUT_ID@" ]
25 27
26 sources = [ 28 sources = [
27 "app_mode_loader_mac.mm", 29 "app_mode_loader_mac.mm",
28 ] 30 ]
29 31
30 deps = [ 32 deps = [
31 "//chrome/common:app_mode_app_support", 33 "//chrome/common:app_mode_app_support",
32 ] 34 ]
33 35
34 # TODO(rsesek): extra_substitutions = [ APP_MODE_APP_BUNDLE_ID ... ]
35
36 libs = [ 36 libs = [
37 "CoreFoundation.framework", 37 "CoreFoundation.framework",
38 "Foundation.framework", 38 "Foundation.framework",
39 ] 39 ]
40 } 40 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698