Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/BUILD.gn

Issue 1950493002: [Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 group("chrome_initial") { 434 group("chrome_initial") {
435 deps = [ 435 deps = [
436 ":chrome_app", 436 ":chrome_app",
437 ] 437 ]
438 } 438 }
439 439
440 mac_app_bundle("chrome_app") { 440 mac_app_bundle("chrome_app") {
441 output_name = chrome_product_full_name 441 output_name = chrome_product_full_name
442 442
443 info_plist = "app/app-Info.plist" 443 info_plist = "app/app-Info.plist"
444 extra_substitutions = [
445 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
446 "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
447 "CHROMIUM_CREATOR=$chrome_mac_creator_code",
448 ]
444 449
445 sources = [ 450 sources = [
446 "app/chrome_exe_main_mac.c", 451 "app/chrome_exe_main_mac.c",
447 ] 452 ]
448 453
449 deps = [ 454 deps = [
450 ":chrome_app_strings_bundle_data", 455 ":chrome_app_strings_bundle_data",
451 ":chrome_resources", 456 ":chrome_resources",
452 ":chrome_versioned_bundle_data", 457 ":chrome_versioned_bundle_data",
453 "//chrome/common:version_header", 458 "//chrome/common:version_header",
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
517 } 522 }
518 group("chrome_app_strings_bundle_data") { 523 group("chrome_app_strings_bundle_data") {
519 public_deps = [] 524 public_deps = []
520 foreach(locale, locales_as_mac_outputs) { 525 foreach(locale, locales_as_mac_outputs) {
521 public_deps += [ ":chrome_app_strings_${locale}_bundle_data" ] 526 public_deps += [ ":chrome_app_strings_${locale}_bundle_data" ]
522 } 527 }
523 } 528 }
524 529
525 bundle_data("chrome_resources") { 530 bundle_data("chrome_resources") {
526 sources = [ 531 sources = [
532 "$root_out_dir/$chrome_mac_bundle_id.manifest",
527 "app/theme/$branding_path_component/mac/app.icns", 533 "app/theme/$branding_path_component/mac/app.icns",
528 "app/theme/$branding_path_component/mac/document.icns", 534 "app/theme/$branding_path_component/mac/document.icns",
529 "browser/ui/cocoa/applescript/scripting.sdef", 535 "browser/ui/cocoa/applescript/scripting.sdef",
530
531 # TODO(rsesek): mac_bundle_id.manifest
532 ] 536 ]
533
534 outputs = [ 537 outputs = [
535 "{{bundle_resources_dir}}/{{source_file_part}}", 538 "{{bundle_resources_dir}}/{{source_file_part}}",
536 ] 539 ]
537 540 public_deps = [
538 deps = [
539 ":chrome_app_strings", 541 ":chrome_app_strings",
542 "//components/policy:chrome_manifest_bundle",
540 ] 543 ]
541 } 544 }
542 545
543 bundle_data("chrome_versioned_bundle_data") { 546 bundle_data("chrome_versioned_bundle_data") {
544 sources = [ 547 sources = [
545 "$root_out_dir/$chrome_framework_name.framework", 548 "$root_out_dir/$chrome_framework_name.framework",
546 "$root_out_dir/$chrome_helper_name.app", 549 "$root_out_dir/$chrome_helper_name.app",
547 ] 550 ]
548 outputs = [ 551 outputs = [
549 "{{bundle_root_dir}}/Versions/$chrome_version_full/{{source_file_part}}", 552 "{{bundle_root_dir}}/Versions/$chrome_version_full/{{source_file_part}}",
550 ] 553 ]
551 public_deps = [ 554 public_deps = [
552 ":chrome_framework", 555 ":chrome_framework",
553 ":chrome_helper_app", 556 ":chrome_helper_app",
554 ] 557 ]
555 } 558 }
556 559
557 mac_app_bundle("chrome_helper_app") { 560 mac_app_bundle("chrome_helper_app") {
558 output_name = chrome_helper_name 561 output_name = chrome_helper_name
559 562
560 info_plist = "app/helper-Info.plist" 563 info_plist = "app/helper-Info.plist"
564 extra_substitutions = [
565 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
566 "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
567 ]
561 568
562 sources = [ 569 sources = [
563 "app/chrome_exe_main_mac.c", 570 "app/chrome_exe_main_mac.c",
564 ] 571 ]
565 572
566 defines = [ "HELPER_EXECUTABLE" ] 573 defines = [ "HELPER_EXECUTABLE" ]
567 574
568 deps = [ 575 deps = [
569 "//chrome/common:version_header", 576 "//chrome/common:version_header",
570 ] 577 ]
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 "app/chrome_crash_reporter_client_mac.mm", 667 "app/chrome_crash_reporter_client_mac.mm",
661 "app/chrome_dll_resource.h", 668 "app/chrome_dll_resource.h",
662 "app/chrome_main.cc", 669 "app/chrome_main.cc",
663 "app/chrome_main_delegate.cc", 670 "app/chrome_main_delegate.cc",
664 "app/chrome_main_delegate.h", 671 "app/chrome_main_delegate.h",
665 "app/chrome_main_mac.h", 672 "app/chrome_main_mac.h",
666 "app/chrome_main_mac.mm", 673 "app/chrome_main_mac.mm",
667 ] 674 ]
668 675
669 info_plist = "app/framework-Info.plist" 676 info_plist = "app/framework-Info.plist"
677 extra_substitutions = [
678 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
679 "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
680 ]
670 681
671 deps = [ 682 deps = [
672 ":browser_dependencies", 683 ":browser_dependencies",
673 ":child_dependencies", 684 ":child_dependencies",
674 ":chrome_framework_helpers", 685 ":chrome_framework_helpers",
675 ":chrome_framework_locales", 686 ":chrome_framework_locales",
676 ":chrome_framework_resources", 687 ":chrome_framework_resources",
677 "//build/config/sanitizers:deps", 688 "//build/config/sanitizers:deps",
678 "//chrome/app/nibs:chrome_xibs", 689 "//chrome/app/nibs:chrome_xibs",
679 "//chrome/common:features", 690 "//chrome/common:features",
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
1347 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1358 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1348 "//chrome/tools/build/linux/chrome-wrapper", 1359 "//chrome/tools/build/linux/chrome-wrapper",
1349 "//third_party/xdg-utils/scripts/xdg-mime", 1360 "//third_party/xdg-utils/scripts/xdg-mime",
1350 "//third_party/xdg-utils/scripts/xdg-settings", 1361 "//third_party/xdg-utils/scripts/xdg-settings",
1351 ] 1362 ]
1352 outputs = [ 1363 outputs = [
1353 "$root_out_dir/{{source_file_part}}", 1364 "$root_out_dir/{{source_file_part}}",
1354 ] 1365 ]
1355 } 1366 }
1356 } 1367 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698