Issue 195049: Merge 25834 - Ensure that tips change when the Chrome language changes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195049: Merge 25834 - Ensure that tips change when the Chrome language changes.... (Closed)

Created:
11 years, 3 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Merge 25834 - Ensure that tips change when the Chrome language changes. BUG= http://crbug.com/21394 TEST= Change chrome language. Close and reopen browser. Tips should appear in new language, or, if not available, they should not appear. Review URL: http://codereview.chromium.org/199073 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25835

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -12 lines)			Patch
	MM	chrome/browser/dom_ui/tips_handler.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download
	MM	chrome/browser/web_resource/web_resource_service.cc	View		2 chunks	+19 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm

On 2009/09/10 02:10:00, laforge wrote:
>