Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 195049: Merge 25834 - Ensure that tips change when the Chrome language changes.... (Closed)

Created:
11 years, 3 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 25834 - Ensure that tips change when the Chrome language changes. BUG= http://crbug.com/21394 TEST= Change chrome language. Close and reopen browser. Tips should appear in new language, or, if not available, they should not appear. Review URL: http://codereview.chromium.org/199073 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
MM chrome/browser/dom_ui/tips_handler.cc View 2 chunks +15 lines, -0 lines 0 comments Download
MM chrome/browser/web_resource/web_resource_service.cc View 2 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 3 months ago (2009-09-10 02:10:00 UTC) #1
Miranda Callahan
11 years, 3 months ago (2009-09-10 02:19:46 UTC) #2
lgtm

On 2009/09/10 02:10:00, laforge wrote:
>

Powered by Google App Engine
This is Rietveld 408576698