Issue 1950473002: Invalidate the previous caret location when editing text nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1950473002: Invalidate the previous caret location when editing text nodes. (Closed)

Created:
4 years, 7 months ago by chrishtr

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Invalidate the previous caret location when editing text nodes. Previously we would miss this invalidation. BUG=603389 Review-Url: https://codereview.chromium.org/1931513003 Cr-Commit-Position: refs/heads/master@{#390982} (cherry picked from commit c8811f690116723cd62bb57ff6e3ff046bc3de42) Committed: https://chromium.googlesource.com/chromium/src/+/5e4151927a5f6a0d3153264eed40fcf26ce53b75

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -0 lines)			Patch
A	third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-before-text-node-update.html	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/CharacterData.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/Document.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/Document.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/editing/FrameSelection.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/editing/FrameSelection.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

chrishtr

4 years, 7 months ago (2016-05-03 17:04:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e4151927a5f6a0d3153264eed40fcf26ce53b75.