Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1950463003: Exclude iOS specific Google Test extensions (Closed)

Created:
4 years, 7 months ago by Petr Hosek
Modified:
4 years, 7 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/build_overrides.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Exclude iOS specific Google Test extensions This is a follow up change which actually disables the iOS specific code which the previous change did not. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4371 R=mcgrathr@chromium.org Committed: https://chromium.googlesource.com/native_client/src/build_overrides/+/2881125066dcf38dae595d92eac8a6b477529116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gtest.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Petr Hosek
4 years, 7 months ago (2016-05-03 17:47:54 UTC) #2
Roland McGrath
lgtm
4 years, 7 months ago (2016-05-03 18:09:10 UTC) #3
Petr Hosek
4 years, 7 months ago (2016-05-03 18:10:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2881125066dcf38dae595d92eac8a6b477529116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698