Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1950443002: PPC: [stubs]: Implement ArrayNoArgumentConstructor as a TF stub (Closed)

Created:
4 years, 7 months ago by JaideepBajwa
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs]: Implement ArrayNoArgumentConstructor as a TF stub Port fa570e55b623c74245945e3bdda042df1bf6a196 R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/b90ba31cd49af14478d5d0d3d807bafe18f664a7 Cr-Commit-Position: refs/heads/master@{#35994}

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed 3rd parameter since its implictly NULL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
JaideepBajwa
PTAL
4 years, 7 months ago (2016-05-03 16:15:42 UTC) #1
MTBrandyberry
lgtm One nitpick comment. https://codereview.chromium.org/1950443002/diff/1/src/ppc/interface-descriptors-ppc.cc File src/ppc/interface-descriptors-ppc.cc (right): https://codereview.chromium.org/1950443002/diff/1/src/ppc/interface-descriptors-ppc.cc#newcode255 src/ppc/interface-descriptors-ppc.cc:255: data->InitializePlatformSpecific(arraysize(registers), registers, NULL); The 3rd ...
4 years, 7 months ago (2016-05-03 16:35:21 UTC) #2
JaideepBajwa
On 2016/05/03 16:35:21, MTBrandyberry wrote: > lgtm > > One nitpick comment. > > https://codereview.chromium.org/1950443002/diff/1/src/ppc/interface-descriptors-ppc.cc ...
4 years, 7 months ago (2016-05-03 17:27:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950443002/20001
4 years, 7 months ago (2016-05-03 17:28:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 17:53:13 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 17:54:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b90ba31cd49af14478d5d0d3d807bafe18f664a7
Cr-Commit-Position: refs/heads/master@{#35994}

Powered by Google App Engine
This is Rietveld 408576698