chrome/browser/resources/settings/settings_main/settings_main.html - Issue 1950423003: MD Settings: Adding "About" page basic structure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 1950423003: MD Settings: Adding "About" page basic structure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@about_page_route

Patch Set: Comment. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/settings_page.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_main/settings_main.html

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html

index 9a5e61204feda1d760317df7db89a336bd0358d2..c4674bf7d764af035da5652fbad154fe4b3f08d4 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.html

+++ b/chrome/browser/resources/settings/settings_main/settings_main.html

@@ -1,4 +1,5 @@

+<link rel="import" href="chrome://md-settings/about_page/about_page.html">

@@ -17,9 +18,7 @@

</settings-advanced-page>

</template>

- <!-- TODO(dpapad): Replace this with <settings-about-page>

- implementation -->

- <div>$i18n{aboutPageTitle}</div>

+ <settings-about-page></settings-about-page>

</template>

</div>

</template>

« no previous file with comments | « chrome/browser/resources/settings/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/settings_page.css » ('j') | no next file with comments »