Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 1950403002: Add the ability to return descedant event listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address pfeldman's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
index 90ea646b43beea7ae69cfa28acfae878bf4e0533..60e7ebae9ae971ded2fac8b88795440a965dcf0c 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
@@ -52,11 +52,17 @@ namespace protocol {
class DictionaryValue;
}
+enum EventListenerFilter {
+ ShowDescendants = 1 << 0,
+ ShowPassive = 1 << 1,
+ ShowBlocking = 1 << 2,
+};
+
class CORE_EXPORT InspectorDOMDebuggerAgent final
: public InspectorBaseAgent<protocol::DOMDebugger::Metainfo> {
WTF_MAKE_NONCOPYABLE(InspectorDOMDebuggerAgent);
public:
- static void eventListenersInfoForTarget(v8::Isolate*, v8::Local<v8::Value>, V8EventListenerInfoList& listeners);
+ static void eventListenersInfoForTarget(v8::Isolate*, v8::Local<v8::Value>, EventListenerFilter filterMask, V8EventListenerInfoList& listeners);
InspectorDOMDebuggerAgent(v8::Isolate*, InspectorDOMAgent*, V8InspectorSession*);
~InspectorDOMDebuggerAgent() override;
@@ -71,7 +77,7 @@ public:
void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
void setXHRBreakpoint(ErrorString*, const String& url) override;
void removeXHRBreakpoint(ErrorString*, const String& url) override;
- void getEventListeners(ErrorString*, const String16& objectId, std::unique_ptr<protocol::Array<protocol::DOMDebugger::EventListener>>* listeners) override;
+ void getEventListeners(ErrorString*, const String16& objectId, const Maybe<bool>& inDescendants, std::unique_ptr<protocol::Array<protocol::DOMDebugger::EventListener>>* listeners) override;
// InspectorInstrumentation API
void willInsertDOMNode(Node* parent);
@@ -108,7 +114,7 @@ private:
void didRemoveBreakpoint();
void setEnabled(bool);
- void eventListeners(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& objectGroup, protocol::Array<protocol::DOMDebugger::EventListener>* listenersArray);
+ void eventListeners(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& objectGroup, EventListenerFilter filterMask, protocol::Array<protocol::DOMDebugger::EventListener>* listenersArray);
std::unique_ptr<protocol::DOMDebugger::EventListener> buildObjectForEventListener(v8::Local<v8::Context>, const V8EventListenerInfo&, const String16& objectGroupId);
v8::Isolate* m_isolate;

Powered by Google App Engine
This is Rietveld 408576698