third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h - Issue 1950403002: Add the ability to return descedant event listeners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 1950403002: Add the ability to return descedant event listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/resources/eventlistener-in-iframe.html ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

index 45827138f8fff17ef306b1f2515223b33338c445..f5dbf2d755c06e59ae7026b140e6eefeafb85054 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

@@ -58,7 +58,7 @@ class CORE_EXPORT InspectorDOMDebuggerAgent final

, public protocol::Backend::DOMDebugger {

WTF_MAKE_NONCOPYABLE(InspectorDOMDebuggerAgent);

public:

- static void eventListenersInfoForTarget(v8::Isolate*, v8::Local<v8::Value>, V8EventListenerInfoList& listeners);

+ static void eventListenersInfoForTarget(v8::Isolate*, v8::Local<v8::Value>, unsigned filterMask, V8EventListenerInfoList& listeners);

InspectorDOMDebuggerAgent(v8::Isolate*, InspectorDOMAgent*, V8InspectorSession*);

~InspectorDOMDebuggerAgent() override;

@@ -73,7 +73,7 @@ public:

void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) override;

void setXHRBreakpoint(ErrorString*, const String& url) override;

void removeXHRBreakpoint(ErrorString*, const String& url) override;

- void getEventListeners(ErrorString*, const String16& objectId, OwnPtr<protocol::Array<protocol::DOMDebugger::EventListener>>* listeners) override;

+ void getEventListeners(ErrorString*, const String16& objectId, const Maybe<bool>& inDescendants, OwnPtr<protocol::Array<protocol::DOMDebugger::EventListener>>* listeners) override;

// InspectorInstrumentation API

void willInsertDOMNode(Node* parent);

@@ -110,7 +110,7 @@ private:

void didRemoveBreakpoint();

void setEnabled(bool);

- void eventListeners(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& objectGroup, protocol::Array<protocol::DOMDebugger::EventListener>* listenersArray);

+ void eventListeners(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& objectGroup, unsigned filterMask, protocol::Array<protocol::DOMDebugger::EventListener>* listenersArray);

PassOwnPtr<protocol::DOMDebugger::EventListener> buildObjectForEventListener(v8::Local<v8::Context>, const V8EventListenerInfo&, const String16& objectGroupId);

v8::Isolate* m_isolate;