Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2033)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 1950403002: Add the ability to return descedant event listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address pfeldman's comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 this.callFunctionPromise(nodeRemoveEventListener).then(storeRemoveFu nction.bind(this)); 565 this.callFunctionPromise(nodeRemoveEventListener).then(storeRemoveFu nction.bind(this));
566 566
567 /** 567 /**
568 * @param {!WebInspector.CallFunctionResult} result 568 * @param {!WebInspector.CallFunctionResult} result
569 * @this {WebInspector.RemoteObject} 569 * @this {WebInspector.RemoteObject}
570 */ 570 */
571 function storeRemoveFunction(result) 571 function storeRemoveFunction(result)
572 { 572 {
573 if (!result.wasThrown && result.object) 573 if (!result.wasThrown && result.object)
574 removeFunction = result.object; 574 removeFunction = result.object;
575 this.target().domdebuggerAgent().getEventListeners(this._objectI d, mycallback.bind(this)); 575 this.target().domdebuggerAgent().getEventListeners(this._objectI d, false, mycallback.bind(this));
pfeldman 2016/06/01 22:40:30 UI should pass the option here.
576 } 576 }
577 577
578 /** 578 /**
579 * @this {!WebInspector.RemoteObject} 579 * @this {!WebInspector.RemoteObject}
580 * @param {?Protocol.Error} error 580 * @param {?Protocol.Error} error
581 * @param {!Array<!DOMDebuggerAgent.EventListener>} payloads 581 * @param {!Array<!DOMDebuggerAgent.EventListener>} payloads
582 */ 582 */
583 function mycallback(error, payloads) 583 function mycallback(error, payloads)
584 { 584 {
585 if (error) { 585 if (error) {
(...skipping 1073 matching lines...) Expand 10 before | Expand all | Expand 10 after
1659 { 1659 {
1660 if (!this._cachedDescription) { 1660 if (!this._cachedDescription) {
1661 var children = this._children(); 1661 var children = this._children();
1662 this._cachedDescription = "{" + this._formatValue(children[0].value) + " => " + this._formatValue(children[1].value) + "}"; 1662 this._cachedDescription = "{" + this._formatValue(children[0].value) + " => " + this._formatValue(children[1].value) + "}";
1663 } 1663 }
1664 return this._cachedDescription; 1664 return this._cachedDescription;
1665 }, 1665 },
1666 1666
1667 __proto__: WebInspector.LocalJSONObject.prototype 1667 __proto__: WebInspector.LocalJSONObject.prototype
1668 } 1668 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698