Calls to HCheckFunction can be eliminated if the value is an HConstant.

Calls to HCheckFunction can be eliminated if the value is an HConstant.

Reland "Calls to HCheckFunction can be eliminated if the value is an HConstant" 
(https://codereview.chromium.org/18751003/).

The CL failed because of heap snapshot issues. alph@chromium.org just checked in
a fix for that (https://code.google.com/p/v8/source/detail?r=15694).

BUG=
R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15704

[mvstanton, 2013-07-17 08:06:44]

Hi Danno, here is the reland of the CL that you and Michael reviewed ~1 week
ago. Thanks!
--Michael

[Sven Panne, 2013-07-17 08:09:56]

Quick DBC for de-obfuscating a predicate :-)

https://codereview.chromium.org/19504007/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/19504007/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:3416: if (!has_double_value_) return unique_id_ ==
other;
return !has_double_value_ && unique_id_ == other;

[danno, 2013-07-17 08:18:52]

LGTM with Sven's comment addressed.

[mvstanton, 2013-07-17 08:45:46]

Predicate duly deobfuscated ;-), thx Sven!
--Michael

https://codereview.chromium.org/19504007/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/19504007/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:3416: if (!has_double_value_) return unique_id_ ==
other;
On 2013/07/17 08:09:56, Sven Panne wrote:
> return !has_double_value_ && unique_id_ == other;

Done.

[mvstanton, 2013-07-17 08:46:08]

Committed patchset #2 manually as r15704 (presubmit successful).