Issue 19504006: More aggressively inline optimized code.

Issue 19504006: More aggressively inline optimized code. (Closed)

Created:
7 years, 5 months ago by Hannes Payer (out of office)

Modified:
7 years, 5 months ago

Reviewers:
titzer, danno, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

More aggressively inline optimized code. BUG= R=danno@chromium.org, mstarzinger@chromium.org, titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15703

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
M	src/compiler.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/debug.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/isolate.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

titzer

LGTM but we could have a flag as well. https://chromiumcodereview.appspot.com/19504006/diff/1/src/compiler.h File src/compiler.h (right): https://chromiumcodereview.appspot.com/19504006/diff/1/src/compiler.h#newcode563 src/compiler.h:563: ...

7 years, 5 months ago (2013-07-17 08:05:01 UTC) #3

Hannes Payer (out of office)

https://chromiumcodereview.appspot.com/19504006/diff/1/src/compiler.h File src/compiler.h (right): https://chromiumcodereview.appspot.com/19504006/diff/1/src/compiler.h#newcode563 src/compiler.h:563: static const int kMaxInliningLevels = 5; On 2013/07/17 08:05:02, ...

7 years, 5 months ago (2013-07-17 08:27:34 UTC) #5

Hannes Payer (out of office)

7 years, 5 months ago (2013-07-17 08:44:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r15703 (presubmit successful).

Expand Messages | Collapse Messages