Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 19504: Fixed escaping/rot13 issue in regexp benchmark (Closed)

Created:
11 years, 10 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fixed issue where \x.. and \u.... were rot13-ed in strings (but not in regexps). IE saved the day by rejecting them.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -33 lines) Patch
M benchmarks/README.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M benchmarks/regexp.js View 2 chunks +31 lines, -31 lines 0 comments Download
M benchmarks/run.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
11 years, 10 months ago (2009-01-30 13:14:02 UTC) #1
Lasse Reichstein
11 years, 10 months ago (2009-01-30 13:18:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698