Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 1950383002: Update docs for profiling Content Shell on Android. (Closed)

Created:
4 years, 7 months ago by jbroman
Modified:
4 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update docs for profiling Content Shell on Android. This needed to be updated to reflect the move from GYP to GN, and to show the more modern alternative to manually invoking perf, which is having Catapult do it for you. BUG=608414 Committed: https://crrev.com/349e3d7cbaf55d319b8c9f2ead66c56033245181 Cr-Commit-Position: refs/heads/master@{#392675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M docs/profiling_content_shell_on_android.md View 4 chunks +31 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbroman
This rearranges things a little, adds instructions for gn, and mentions how to use adb_profile_chrome ...
4 years, 7 months ago (2016-05-06 00:34:18 UTC) #2
jbroman
ping
4 years, 7 months ago (2016-05-10 17:38:40 UTC) #3
jbudorick
On 2016/05/10 17:38:40, jbroman wrote: > ping Sorry about the delay. lgtm
4 years, 7 months ago (2016-05-10 17:42:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950383002/1
4 years, 7 months ago (2016-05-10 17:58:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 19:15:28 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 19:18:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/349e3d7cbaf55d319b8c9f2ead66c56033245181
Cr-Commit-Position: refs/heads/master@{#392675}

Powered by Google App Engine
This is Rietveld 408576698