Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1950343003:
DevTools: blur previous element when focus changes (Closed)
|
Created:
4 years, 7 months ago by luoe Modified:
4 years, 7 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: blur previous element when focus changes
BUG=609013
Committed: https://crrev.com/afe5fb69c6324250594694f76e87b2de824e49e2
Cr-Commit-Position: refs/heads/master@{#392489}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 29 (15 generated)
Description was changed from ========== DevTools: blur previous element when focus changes BUG=609013 ========== to ========== DevTools: blur previous element when focus changes Resizing will trigger the GlassPane to open. When it closes, our current focus logic calls inspectorView.focus(), which in turn, takes the current element (e.g. Elements panel's element), and calls the .focus(). When the new element isn't a focusable field, the old element doesn't blur, which maintains its 'focus outline'. BUG=609013 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
Description was changed from ========== DevTools: blur previous element when focus changes Resizing will trigger the GlassPane to open. When it closes, our current focus logic calls inspectorView.focus(), which in turn, takes the current element (e.g. Elements panel's element), and calls the .focus(). When the new element isn't a focusable field, the old element doesn't blur, which maintains its 'focus outline'. BUG=609013 ========== to ========== DevTools: blur previous element when focus changes BUG=609013 ==========
Resizing will trigger the GlassPane to open. When it closes, our current focus logic calls inspectorView.focus(), which in turn, takes the current element (e.g. Elements panel's element), and calls the .focus(). When the new element isn't a focusable field, the old element doesn't blur, which maintains its 'focus outline'.
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950343003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950343003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950343003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950343003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950343003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/1950343003/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950343003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950343003/20001
Message was sent while issue was closed.
Description was changed from ========== DevTools: blur previous element when focus changes BUG=609013 ========== to ========== DevTools: blur previous element when focus changes BUG=609013 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: blur previous element when focus changes BUG=609013 ========== to ========== DevTools: blur previous element when focus changes BUG=609013 Committed: https://crrev.com/afe5fb69c6324250594694f76e87b2de824e49e2 Cr-Commit-Position: refs/heads/master@{#392489} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/afe5fb69c6324250594694f76e87b2de824e49e2 Cr-Commit-Position: refs/heads/master@{#392489}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1976283002/ by luoe@chromium.org. The reason for reverting is: This patchset breaks the ability to hide the color picker popover in some cases. See https://bugs.chromium.org/p/chromium/issues/detail?id=611803 Reverting will break the original bug, affecting focus in the full text search drawer.. |
