Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1950333003: Fix a corner case of inferred types with function-typed parameters. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a corner case of inferred types with function-typed parameters. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b992be5569f214c2ca7093181bf25bbac8f156db

Patch Set 1 #

Patch Set 2 : Also test resynthesis. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -14 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +12 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 1 chunk +14 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-06 16:44:51 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1950333003/diff/20001/pkg/analyzer/test/src/summary/resynthesize_test.dart File pkg/analyzer/test/src/summary/resynthesize_test.dart (right): https://codereview.chromium.org/1950333003/diff/20001/pkg/analyzer/test/src/summary/resynthesize_test.dart#newcode3360 pkg/analyzer/test/src/summary/resynthesize_test.dart:3360: test_inferred_type_refers_to_nested_function_typed_param_of_typedef() { Is it really "of typedef"?
4 years, 7 months ago (2016-05-06 16:49:43 UTC) #3
Paul Berry
https://codereview.chromium.org/1950333003/diff/20001/pkg/analyzer/test/src/summary/resynthesize_test.dart File pkg/analyzer/test/src/summary/resynthesize_test.dart (right): https://codereview.chromium.org/1950333003/diff/20001/pkg/analyzer/test/src/summary/resynthesize_test.dart#newcode3360 pkg/analyzer/test/src/summary/resynthesize_test.dart:3360: test_inferred_type_refers_to_nested_function_typed_param_of_typedef() { On 2016/05/06 16:49:43, scheglov wrote: > Is ...
4 years, 7 months ago (2016-05-06 16:54:37 UTC) #4
Paul Berry
4 years, 7 months ago (2016-05-06 16:54:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b992be5569f214c2ca7093181bf25bbac8f156db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698