Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 1950333002: Remove url scheme from the chooser bubble title on Mac (Closed)

Created:
4 years, 7 months ago by juncai
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove url scheme from the chooser bubble title on Mac To be the same with the title of other bubbles such as notification, geo location, etc., the title of the chooser bubble needs to remove the url scheme. For example, it needs to show: "example.com wants to connect to:" instead of: "https://example.com wants to connect to:" BUG=609521, 529950 Committed: https://crrev.com/9895021bcaad569bc377b6f53b5adcd2f1a34779 Cr-Commit-Position: refs/heads/master@{#391845}

Patch Set 1 : remove url scheme from the chooser bubble title on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
juncai
Please take a look.
4 years, 7 months ago (2016-05-05 17:20:45 UTC) #2
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-05 17:24:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950333002/1
4 years, 7 months ago (2016-05-05 17:27:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 18:16:48 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 18:18:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9895021bcaad569bc377b6f53b5adcd2f1a34779
Cr-Commit-Position: refs/heads/master@{#391845}

Powered by Google App Engine
This is Rietveld 408576698