Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: ios/web/shell/test/web_shell_navigation_egtest.mm

Issue 1950323002: Refactor web shell integration tests utilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add gn Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/shell/test/shell_matchers.mm ('k') | ios/web/shell/test/web_shell_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/shell/test/web_shell_navigation_egtest.mm
diff --git a/ios/web/shell/test/web_shell_navigation_egtest.mm b/ios/web/shell/test/web_shell_navigation_egtest.mm
index d48ba1903da9cb3156aad17879903ce16dcf7c2c..a9a197401fcaf5dc315dd2f6071029a0542d392d 100644
--- a/ios/web/shell/test/web_shell_navigation_egtest.mm
+++ b/ios/web/shell/test/web_shell_navigation_egtest.mm
@@ -11,9 +11,9 @@
#include "base/strings/sys_string_conversions.h"
#import "ios/web/public/test/http_server.h"
#include "ios/web/public/test/http_server_util.h"
-#include "ios/web/shell/test/navigation_test_util.h"
-#import "ios/web/shell/test/shell_matchers.h"
-#import "ios/web/shell/test/web_view_matchers.h"
+#include "ios/web/public/test/navigation_test_util.h"
+#include "ios/web/shell/test/app/web_shell_test_util.h"
+#import "ios/web/shell/test/earl_grey/shell_matchers.h"
// Navigation test cases for the web shell. These are Earl Grey integration
// tests, which are based on XCTest.
@@ -62,12 +62,14 @@
web::test::SetUpSimpleHttpServer(responses);
- web::navigation_test_util::LoadUrl(URL1);
+ web::WebState* webState = web::web_shell_test_util::GetCurrentWebState();
+
+ web::navigation_test_util::LoadUrl(webState, URL1);
[[EarlGrey selectElementWithMatcher:web::webViewContainingText(response1)]
assertWithMatcher:grey_notNil()];
- web::navigation_test_util::LoadUrl(URL2);
+ web::navigation_test_util::LoadUrl(webState, URL2);
[[EarlGrey selectElementWithMatcher:web::webViewContainingText(response2)]
assertWithMatcher:grey_notNil()];
« no previous file with comments | « ios/web/shell/test/shell_matchers.mm ('k') | ios/web/shell/test/web_shell_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698