ios/web/shell/test/navigation_test_util.h - Issue 1950323002: Refactor web shell integration tests utilities.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/shell/test/navigation_test_util.h

Issue 1950323002: Refactor web shell integration tests utilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix imports and includes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #ifndef IOS_WEB_SHELL_TEST_NAVIGATION_TEST_UTIL_H_

6 #define IOS_WEB_SHELL_TEST_NAVIGATION_TEST_UTIL_H_

7

8 #include "url/gurl.h"

9

10 namespace web {

11 namespace navigation_test_util {

12

13 // Loads \|url\| in current webState with transition of type

14 // ui::PAGE_TRANSITION_TYPED.

15 void LoadUrl(GURL url);
Eugene But (OOO till 7-30) 2016/05/05 21:43:41 Maybe you should keep this method and use \|void Lo Maybe you should keep this method and use \|void LoadUrl(web::WebState, const GURL&);\| in the implementation? Passing web state to LoadUrl seems to be unnecessary burden for a test writer. baxley* 2016/05/05 22:03:25 Mind if I save it for a follow up CL? Show quoted text On 2016/05/05 21:43:41, Eugene But wrote: > Maybe you should keep this method and use \|void LoadUrl(web::WebState, const > GURL&);\| in the implementation? > Passing web state to LoadUrl seems to be unnecessary burden for a test writer. Mind if I save it for a follow up CL? Eugene But (OOO till 7-30)* 2016/05/05 22:22:44 Sure. Show quoted text On 2016/05/05 22:03:25, baxley wrote: > On 2016/05/05 21:43:41, Eugene But wrote: > > Maybe you should keep this method and use \|void LoadUrl(web::WebState*, const > > GURL&);\| in the implementation? > > Passing web state to LoadUrl seems to be unnecessary burden for a test writer. > > Mind if I save it for a follow up CL? Sure.
16

17 } // namespace navigation_test_util

18 } // namespace web

19

20 #endif // IOS_WEB_SHELL_TEST_NAVIGATION_TEST_UTIL_H_

OLD	NEW

« ios/web/shell/test/earl_grey/shell_matchers.mm ('K') | « ios/web/shell/test/earl_grey/shell_matchers.mm ('k') | ios/web/shell/test/navigation_test_util.mm » ('j') | no next file with comments »