Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: base/trace_event/common/trace_event_common.h

Issue 1950313005: [tracing] Move and rename TRACE_EVENT_API_TASK_EXECUTION_EVENT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_missing_task
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/heap_profiler.h » ('j') | base/trace_event/trace_event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/common/trace_event_common.h
diff --git a/base/trace_event/common/trace_event_common.h b/base/trace_event/common/trace_event_common.h
index 7a1533ed822e884005234aa66bce588dec44299c..259ca3afec0821332258c369ddda0bff58603657 100644
--- a/base/trace_event/common/trace_event_common.h
+++ b/base/trace_event/common/trace_event_common.h
@@ -928,11 +928,11 @@
// Special trace event macro to trace task execution with the location where it
// was posted from.
-#define TRACE_TASK_EXECUTION(run_function, task) \
- TRACE_EVENT2("toplevel", run_function, "src_file", \
- (task).posted_from.file_name(), "src_func", \
- (task).posted_from.function_name()); \
- TRACE_EVENT_API_SCOPED_TASK_EXECUTION_EVENT INTERNAL_TRACE_EVENT_UID( \
+#define TRACE_TASK_EXECUTION(run_function, task) \
+ TRACE_EVENT2("toplevel", run_function, "src_file", \
+ (task).posted_from.file_name(), "src_func", \
+ (task).posted_from.function_name()); \
+ HEAP_PROFILER_API_SCOPED_TASK_EXECUTION_EVENT INTERNAL_TRACE_EVENT_UID( \
Primiano Tucci (use gerrit) 2016/05/09 17:36:45 I'd still name it with TRACE_ prefix so folks real
ssid 2016/05/09 23:49:11 Done.
task_event)((task).posted_from.file_name());
// TRACE_EVENT_METADATA* events are information related to other
« no previous file with comments | « no previous file | base/trace_event/heap_profiler.h » ('j') | base/trace_event/trace_event.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698