[DevTools] Add additional accessor check in InjectedScriptSource.js

third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8InjectedScriptHost.h"
 
 #include "platform/inspector_protocol/String16.h"
 #include "platform/v8_inspector/InjectedScriptNative.h"
 #include "platform/v8_inspector/V8Compat.h"
 #include "platform/v8_inspector/V8DebuggerImpl.h"
@@ skipping 51 matching lines @@
 {
     if (info.Length() < 1 || !info[0]->IsObject())
         return;
 
     v8::Local<v8::Object> object = info[0].As<v8::Object>();
     info.GetReturnValue().Set(object->GetConstructorName());
 }
 
 void V8InjectedScriptHost::formatAccessorsAsProperties(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
-    if (info.Length() < 1)
+    ASSERT(info.Length() == 2);
+    info.GetReturnValue().Set(false);
+    if (!info[1]->IsFunction())

[dgozman, 2016/05/23 15:53:03]

How this could be possible? Why do we return |false| and not |true| then?

[kozy, 2016/05/23 17:05:12]

It could be undefined and we don't want to format this kind of accessor as
property.

"get
A function which serves as a getter for the property, or undefined if there is
no getter (accessor descriptors only)." [1]

[1]
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

         return;
-
+    if (info[1].As<v8::Function>()->ScriptId() != v8::UnboundScript::kNoScriptId)

[dgozman, 2016/05/23 15:53:03]

Let's comment that this means user-defined code.

[kozy, 2016/05/23 17:05:12]

Done.

+        return;
     info.GetReturnValue().Set(unwrapDebugger(info)->client()->formatAccessorsAsProperties(info[0]));
 }
 
 void V8InjectedScriptHost::subtypeCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 1)
         return;
 
     v8::Isolate* isolate = info.GetIsolate();
     v8::Local<v8::Value> value = info[0];
@@ skipping 247 matching lines @@
 {
     return v8::Private::ForApi(isolate, toV8StringInternalized(isolate, "V8Debugger#scopeExtension"));
 }
 
 bool V8Debugger::isRemoteObjectAPIMethod(const String16& name)
 {
     return name == "bindRemoteObject";
 }
 
 } // namespace blink